[FFmpeg-devel] [PATCH] avfilter: add BobWeaver deinterlacing filter

[James Almer]

On 6/19/2016 4:52 PM, Thomas Mundt wrote:
> James Almer schrieb am So, 19.6.2016:
>> On 2/7/2016 8:39 PM, Thomas Mundt wrote:
>>> + at item deint
>>> +Specify which frames to deinterlace. Accept one of the following
>>> +values:
>>> + 
>>> + at table @option
>>> + at item 0, all
>>> +Deinterlace all frames.
>>> + at item 1, interlaced
>>> +Only deinterlace frames marked as interlaced.
>>> + at end table
>>> + 
>>> +The default value is @code{all}.
>>
>> This...
>>
>> [...]
>>
>>> +    { "deint", "specify which frames to deinterlace", OFFSET(deint), AV_OPT_TYPE_INT, {.i64=BWDIF_DEINT_INTERLACED}, 0, 1, FLAGS, "deint" },
>>
>> ...and this don't match. So either fix the docs line or change the
>> default here.
>> Bump lavfi micro version of you change the default.
>>
>> For the record, every other deinterlace filter seems to default to
>> "all".
>>
>>> +    CONST("all",        "deinterlace all frames",                       BWDIF_DEINT_ALL,        "deint"),
>>> +    CONST("interlaced", "only deinterlace frames marked as interlaced", BWDIF_DEINT_INTERLACED, "deint"),
> 
> Oops, I also placed the documentation at the wrong alphabetical position.
> Patches attached.
> Sorry about that!!
> 
> Thomas

Both applied, thanks!