[FFmpeg-devel] [PATCH] Respect payload offset in av_grow_packet

Michael Niedermayer michael at niedermayer.cc
Thu Jun 2 00:45:39 CEST 2016


On Wed, May 25, 2016 at 05:58:33PM +0300, Andriy Lysnevych wrote:
> > data_offset should probably be size_t, thats also what offsetof() would
> > give
> > a pointer difference can be larger than INT_MAX
> 
> Done
> 
> > also please add a av_assert0 that pkt->data is not NULL or handle that
> > case
> 
> Done NULL data handling but it makes code more complex. Please check.
> 
> > as pkt->size can be 0 iam not sure pkt->data is guranteed to be non
> > null
> 
> It should work with pkt->size = 0 for both reference counted and
> not-reference counted packets without memory leak. It should allocate
> just padding and zeroize it.

>  avpacket.c |   28 +++++++++++++++++++++-------
>  1 file changed, 21 insertions(+), 7 deletions(-)
> 1f6f2b7fe3cbb95616537b4509cd8751b9a24aaa  0001-Respect-payload-offset-in-av_grow_packet.patch
> From b92cc763ebb4e9f16989da442af745a78a9c2501 Mon Sep 17 00:00:00 2001
> From: Andriy Lysnevych <andriy.lysnevych at gmail.com>
> Date: Wed, 25 May 2016 17:56:21 +0300
> Subject: [PATCH] Respect payload offset in av_grow_packet

applied

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160602/f3ba60c0/attachment.sig>


More information about the ffmpeg-devel mailing list