[FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727
pburt0 at gmail.com
Thu Jul 28 08:18:01 EEST 2016
> My suggestion is that you send your public key to
> Michael and commit yourself including adding yourself
> as maintainer of hdcd.
I don't know enough about what that would mean. I'm also not
an expert user of git.
>> One strange case is John Mellencamp -  Mr. Happy Go Lucky
>> 06. Emotional Love, where there is one extra HDCD packet in one
>> channel, and that target_gain value ends up being ignored.
> Is this a regression against the code in current git head?
> Or just a (possibly) unsolved issue?
This patch causes the target_gain in that packet to be ignored, where
before it would not have been. This is correct, however, if you're trying
to replicate HDCD decoding as described in the paper mentioned in #5727.
Although, aside from being unmatched in the other channel, the packet
appears completely legit. Its just a weird example where the output is
different with the new code. Most of the time the two processing modes
output is exactly the same.
>> This patch is against master, so it also includes the changes in an
>> earlier (not yet applied) patch set for HDCD detection, PE mode,
>> cdt counter, and code comments.
> Please split the patches as much as it makes sense.
Those other patches have been applied today. I'll split this one up and
resubmit as a set.
More information about the ffmpeg-devel