[FFmpeg-devel] [PATCH] libavformat/matroskadec: fix unsigned overflow to improve seeking
chcunningham at chromium.org
Tue Jul 26 21:48:59 EEST 2016
Happy to make a test. Stand by for patch.
On Sat, Jul 23, 2016 at 2:26 AM, Michael Niedermayer <michael at niedermayer.cc
> On Thu, Jul 21, 2016 at 12:01:45PM -0700, Chris Cunningham wrote:
> > When seeking a file where codec delay is greater than 0, the timecode
> > can become negative after offsetting by the codec delay. Failing to cast
> > to a signed int64 will cause the check against skip_to_timecode to
> > true for these negative values. This breaks the "skip_to" seek mechanism.
> > ---
> > libavformat/matroskadec.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> can you create a fate testcase for this ?
> (maybe libavformat/tests/seek.c could be used)
> i can upload the sample file to the fate-samples
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> While the State exists there can be no freedom; when there is freedom there
> will be no State. -- Vladimir Lenin
More information about the ffmpeg-devel