[FFmpeg-devel] [PATCH] lavc: always build dnxhddata

Michael Niedermayer michael at niedermayer.cc
Mon Jul 25 10:36:21 EEST 2016


On Sun, Jul 24, 2016 at 11:43:41PM -0300, James Almer wrote:
> On 7/24/2016 8:13 PM, Michael Niedermayer wrote:
[...]
> > 
> >>
> >> Looking at this function closely now, it could have been added
> >> to dnxhddata.h instead. No need for avpriv_ prefix and to
> >> forcefully build an object file full of data tables that it
> >> doesn't need.
> > 
> > agree, this would be best in this case
> 
> Are you ok with me reverting this commit and moving the function
> to the header? The symbol will of course not be removed until next
> major bump since it's already in a release.
> Alternatively apply "[PATCH] lavf/movenc: add missing dependency
> on dnxhddata" but IMO it's better to just move the thing to the
> header.

yes, moving to the header is better

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160725/22ccfb57/attachment.sig>


More information about the ffmpeg-devel mailing list