[FFmpeg-devel] libavcodec : add psd image file decoder

Michael Niedermayer michael at niedermayer.cc
Sat Jul 23 21:07:34 EEST 2016


On Sat, Jul 23, 2016 at 04:37:19PM +0200, Martin Vignali wrote:
> Hello,
> 
> New patch in attach.
> 
> - add support for RLE compression (who can be use by Photoshop and After
> Effects)
> 
> RLE samples can be found here :
> https://we.tl/LCQLqwuvZ4
> 
> - fix trouble with not even width.
> - modification of the probe function, but i'm not sure of mine for this
> - cosmetics fix.
> 
> 
> Comments welcome
> 
> 
> Martin
> Jokyo Images

>  Changelog                |    1 
>  doc/general.texi         |    2 
>  libavcodec/Makefile      |    1 
>  libavcodec/allcodecs.c   |    1 
>  libavcodec/avcodec.h     |    1 
>  libavcodec/codec_desc.c  |    7 
>  libavcodec/psd.c         |  395 +++++++++++++++++++++++++++++++++++++++++++++++
>  libavformat/Makefile     |    1 
>  libavformat/allformats.c |    1 
>  libavformat/img2.c       |    1 
>  libavformat/img2dec.c    |   25 ++
>  11 files changed, 436 insertions(+)
> f973f04b071009eefd40211d7ccc759a0236d358  0001-libavcodec-add-decoder-for-.psd-image-file.patch
> From 18de7ec132fb1c599a40baa7c1a04ca08134ed7e Mon Sep 17 00:00:00 2001
> From: Martin Vignali <martin.vignali at gmail.com>
> Date: Sat, 23 Jul 2016 16:20:07 +0200
> Subject: [PATCH] libavcodec : add decoder for .psd image file.

breaks fate

make: *** [fate-filter-metadata-ebur128] Error 1
--- -   2016-07-23 18:50:11.633752058 +0200
+++ tests/data/fate/probe-format-roundup1414    2016-07-23 18:50:10.913635588 +0200
@@ -1 +1 @@
-mpeg
+psd_pipe
Test probe-format-roundup1414 failed. Look at tests/data/fate/probe-format-roundup1414.err for details.
make: *** [fate-probe-format-roundup1414] Error 1
--- -   2016-07-23 18:50:11.657384876 +0200
+++ tests/data/fate/probe-format-roundup997     2016-07-23 18:50:10.917635588 +0200
@@ -1 +1 @@
-mpeg
+psd_pipe
Test probe-format-roundup997 failed. Look at tests/data/fate/probe-format-roundup997.err for details.
make: *** [fate-probe-format-roundup997] Error 1
--- -   2016-07-23 18:50:11.667958765 +0200
+++ tests/data/fate/probe-format-roundup1383    2016-07-23 18:50:10.917635588 +0200
@@ -1 +1 @@
-mp3
+psd_pipe
Test probe-format-roundup1383 failed. Look at tests/data/fate/probe-format-roundup1383.err for details.
make: *** [fate-probe-format-roundup1383] Error 1
make: Target `fate' not remade because of errors.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160723/3dade468/attachment.sig>


More information about the ffmpeg-devel mailing list