[FFmpeg-devel] [PATCH 1/2] avcodec/bsf: Check side data when setting BSF EOF flag.

Nicolas George george at nsup.org
Fri Jul 22 21:21:24 EEST 2016

Le quintidi 5 thermidor, an CCXXIV, sebechlebskyjan at gmail.com a écrit :
>  I believe that side data should be checked too, and 
>  EOF flag set only when both data and side data are
>  not present.
>  I was testing new list BSF API I was working on,
>  and with simple pass-though (empty list) BSF filter,
>  some tests were failing because packets containing only
>  side data were taken as EOF signal for bitsteam filter. 
>  Also, I've added comment about this behaviour in next
>  patch.

I think we should be more strict, not less: pkt == NULL means EOF, pkt with
data and/or side data is normal, and pkt != NULL without data and side data
is forbidden and reserved for future extension.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160722/15560b0d/attachment.sig>

More information about the ffmpeg-devel mailing list