[FFmpeg-devel] [PATCH 2/2] SCTE-35 support in hlsenc

Michael Niedermayer michael at niedermayer.cc
Fri Jul 22 03:54:04 EEST 2016


On Thu, Jul 21, 2016 at 03:31:32PM -0700, Carlos Fernandez Sanz wrote:
> From: carlos <carlos at ccextractor.org>
> 
> Signed-off-by: carlos <carlos at ccextractor.org>
> ---
>  libavformat/Makefile  |   1 +
>  libavformat/hlsenc.c  | 179 +++++++++++-------
>  libavformat/scte_35.c | 489 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  libavformat/scte_35.h |  76 ++++++++
>  4 files changed, 680 insertions(+), 65 deletions(-)
>  create mode 100644 libavformat/scte_35.c
>  create mode 100644 libavformat/scte_35.h

this also fails to build on mingw64:

src/libavformat/scte_35.c: In function ‘parse_insert_cmd’:
src/libavformat/scte_35.c:207:5: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]
src/libavformat/scte_35.c:208:5: error: implicit declaration of function ‘localtime’ [-Werror=implicit-function-declaration]
src/libavformat/scte_35.c:208:14: warning: assignment makes pointer from integer without a cast [enabled by default]
src/libavformat/scte_35.c:209:5: error: implicit declaration of function ‘strftime’ [-Werror=implicit-function-declaration]
src/libavformat/scte_35.c:209:5: warning: incompatible implicit declaration of built-in function ‘strftime’ [enabled by default]
cc1: some warnings being treated as errors
make: *** [libavformat/scte_35.o] Error 1
make: *** Waiting for unfinished jobs....

maybe missing some include
also localtime() is not thread safe, please use localtime_r()
with include  libavutil/time_internal.h

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160722/0864cf22/attachment.sig>


More information about the ffmpeg-devel mailing list