[FFmpeg-devel] [PATCH 1/7] avformat/utils: Add ff_stream_encode_params_copy()

Jan Sebechlebsky sebechlebskyjan at gmail.com
Tue Jul 12 00:09:02 EEST 2016



On 07/11/2016 02:23 AM, Marton Balint wrote:
>
>> +    ret = av_dict_copy(&dst->metadata, src->metadata, 0);
>> +    if (ret < 0)
>> +        return ret;
>
> Since you are resetting every existing field in dst, it might make 
> sense to free the metadata dictionary as well, before copying items to 
> it.
>
Thanks for noticing, I've fixed that, I will wait for Nicolas's reply 
regarding duration field and then send the modified patch.

Regards,
Jan



More information about the ffmpeg-devel mailing list