[FFmpeg-devel] [PATCH] libavformat: Add FIFO pseudo-muxer

[Jan Sebechlebsky]

Hello Moritz,
Thanks for feedback and help with grammar! I'll include your fixes in 
the next version of patch, which I'm planning to send today.

On 07/02/2016 08:49 PM, Moritz Barsnick wrote:
>> +#define FIFO_DEFAULT_RECOVERY_WAIT_TIME    1000000 // 1 second
> ???? You're assigning it as a default to an option which claims to be
> in seconds:
>
>> +        {"recovery_wait_time", "Waiting time between recovery attempts (seconds)", OFFSET(recovery_wait_time),
>> +         AV_OPT_TYPE_DURATION, {.i64 = FIFO_DEFAULT_RECOVERY_WAIT_TIME}, 0, INT64_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> So the default you are setting happens to be 1000000 seconds. Or am I
> missing something? (I could check by applying your patch. Sorry, didn't
> do so.)
I agree this is confusing - The type of the recovery_wait_time option is 
"duration" which allows you to enter duration in several formats and 
converts it to the microseconds. So, when you enter an integer it 
actually takes this number for a number of seconds and converts it to 
the microseconds. The default value is therefore really just 1 second.
I will change the constant name to FIFO_DEFAULT_RECOVERY_WAIT_TIME_USEC 
and take a look at how "duration" options are usually documented.

Thank you for your help

Regards,
Jan