[FFmpeg-devel] [PATCH] libavcodec/mmaldec.c: add interlaced_frame and format struct to AVFrame for deinterlacing

[Jens Ziller]

Am Samstag, den 02.07.2016, 17:54 +0200 schrieb Moritz Barsnick:
> On Sun, Jun 26, 2016 at 17:12:14 +0200, Jens Ziller wrote:
> > 
> > +        ctx->interlaced_frame = !(interlace_type.eMode ==
> > MMAL_InterlaceProgressive);
> What's wrong with using the "!=" operator instead?

"!=" is a comparing. "= !()" assign with a negate. Here is "= !()"
needed.

> 
> > 
> >      if (avctx->pix_fmt == AV_PIX_FMT_MMAL) {
> >          if (!ctx->pool_out)
> > +        // in data[2] give the format struct for configure
> > deinterlacer and renderer
> > +        frame->data[2] = ctx->decoder->output[0]->format;
> Incorrect indentation.

My fault.

The new patch is attached. Please integrate the patch. That I can
release my App who deal with it.

Regards Jens

> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-v3-fill-AVFrame-interlaced_frame-with-MMAL_PARAMETER.patch
Type: text/x-patch
Size: 3114 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160703/35ffb3b0/attachment.bin>