[FFmpeg-devel] [PATCH] lavc/rawdec: Only use AV_PIX_FMT_PAL8 for 1 bpp video

[Michael Niedermayer]

On Sun, Jan 31, 2016 at 01:33:02PM +0100, wm4 wrote:
> On Sun, 31 Jan 2016 13:27:22 +0100
> Mats Peterson <matsp888-at-yahoo.com at ffmpeg.org> wrote:
> 
> > I don't really appreciate that you're doing things behind my back, 
> > Michael. There's nothing mentioned on the ffmpeg-devel mailing list 
> > about your "monowhite switching patch". Furthermore, to me it's highly 
> > unncecessary to use monowhite whatsoever. The space savings are quite 
> > irrelevant nowadays, and the logic to detect whether a file is black & 
> > white only creates more noise in the code. Here's a patch that restores 
> > the old behaviour of only using pal8 for 1 bpp video, and removes 
> > superfluous monowhite stuff.
> 
> Less complexity for such a corner case sounds indeed better.

i dont mind reverting my patch if people prefer

but
converting from monochrome avis/nuts/others? to other formats would
not store monochrome but paletted or RGB then

heres an example with tiff:

./ffmpeg      -i test.avi -vframes 1 test.tiff
./ffmpeg-ref  -i test.avi -vframes 1 test-ref.tiff

-rw-r----- 1 michael michael  804 Jan 31 15:15 test-ref.tiff
-rw-r----- 1 michael michael 3592 Jan 31 15:15 test.tiff


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160131/1a29c7a6/attachment.sig>