[FFmpeg-devel] [PATCH] lavc/rawdec: Remove superfluous AV_PIX_FMT_MONOWHITE code

[Michael Niedermayer]

On Sun, Jan 31, 2016 at 12:19:21PM +0100, Mats Peterson wrote:
> On 01/31/2016 11:31 AM, Michael Niedermayer wrote:
> >On Sun, Jan 31, 2016 at 01:34:46AM +0100, Mats Peterson wrote:
> >>On 01/30/2016 05:10 AM, Mats Peterson wrote:
> >>>Now when both AVI and QuickTime use pal8 for 1 bpp video, there's no
> >>>need to keep the monow stuff.
> >>>
> >>I should add that I'm only removing stuff that I've added myself
> >>before, so don't worry.
> >
> >should this still be applied after
> >6ffac5d33d334f847150356293ecb6f9eaf69e15 ?
> >
> >[...]
> >
> >
> >
> >_______________________________________________
> >ffmpeg-devel mailing list
> >ffmpeg-devel at ffmpeg.org
> >http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> 
> I've obviously missed that one, Michael, but I don't see the reason
> to switch to monow whatsoever. The space saving of using monow
> rather than pal8 for 1 bpp data is rather irrelevant nowadays. Your
> mileage may vary, of course. And in order to be consequent, this
> would have to be done for 1 bpp QuickTime Animation (qtrle) as well.

it can be done for qtrle too, if one wants

the space savings are significant, heres a 10second video to show this

./ffmpeg -pix_fmt monow -f rawvideo  -s cif -i /dev/zero -t 10 -vcodec rawvideo test.avi
./ffmpeg -i test.avi -vcodec rawvideo  out.avi
./ffmpeg-ref -i test.avi -vcodec rawvideo  out-ref.avi

-rw-r----- 1 michael michael 25611686 Jan 31 14:34 out.avi
-rw-r----- 1 michael michael  3179686 Jan 31 14:34 out-ref.avi
-rw-r----- 1 michael michael  3179686 Jan 31 14:31 test.avi

and since the table lists PAL8, muxing produces this
warning:
[avi @ 0x2d51940] monow rawvideo cannot be written to avi, output file will be unreadable
the resulting file seems ok though

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

For every action, there is an equal and opposite reaction. -- Newton
For every man jailed for a minor crime, theres one person more that
will hate the government, some of them will become terrorists.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160131/ec7115ce/attachment.sig>