[FFmpeg-devel] [PATCH 3/3] ffmpeg_dxva2: add a profile check for hevc

[Michael Niedermayer]

On Sat, Jan 30, 2016 at 05:03:39PM +0100, Hendrik Leppkes wrote:
> On Thu, Jan 28, 2016 at 3:52 PM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> > On Thu, Jan 28, 2016 at 12:58:27PM +0100, Hendrik Leppkes wrote:
> >> ---
> >>  ffmpeg_dxva2.c | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/ffmpeg_dxva2.c b/ffmpeg_dxva2.c
> >> index 1b62bb9..35bedec 100644
> >> --- a/ffmpeg_dxva2.c
> >> +++ b/ffmpeg_dxva2.c
> >> @@ -637,6 +637,12 @@ int dxva2_init(AVCodecContext *s)
> >>          return AVERROR(EINVAL);
> >>      }
> >>
> >> +    if (s->codec_id == AV_CODEC_ID_HEVC &&
> >> +        s->profile != FF_PROFILE_HEVC_MAIN && s->profile != FF_PROFILE_HEVC_MAIN_10) {
> >> +        av_log(NULL, loglevel, "Unsupported HEVC profile for DXVA2 HWAccel: %d\n", s->profile);
> >                   ^^^^
> > this should be some context if possible
> >
> > otherwise LGTM
> >
> 
> The entire file doesn't use contexts for some reason, I would rather
> keep it like this in this patch and then send a follow up to make all
> the log commands in that file use contexts.

sure, whatever you prefer

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160130/96183c72/attachment.sig>