[FFmpeg-devel] [FFmpeg-cvslog] build: use a link instead of changing current directory when compiling

[Michael Niedermayer]

On Sat, Jan 30, 2016 at 01:12:15AM +0100, Andreas Cadhalpun wrote:
> On 28.01.2016 15:42, Michael Niedermayer wrote:
> > On Wed, Jan 27, 2016 at 11:52:28PM +0100, Andreas Cadhalpun wrote:
> >>  Makefile  |    5 ++++-
> >>  configure |    2 +-
> >>  2 files changed, 5 insertions(+), 2 deletions(-)
> >> 67bd05c13361082708ccc24ee5828c4c00a443a3  0001-configure-fall-back-to-using-full-path-if-src-is-a-d.patch
> >> From 3dcdf81a2db324316c956553340bf42ce5d51278 Mon Sep 17 00:00:00 2001
> >> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> Date: Tue, 26 Jan 2016 22:54:01 +0100
> >> Subject: [PATCH] configure: fall back to using full path if src is a directory
> >>
> >> And don't try to remove src on distclean in that case.
> >>
> >> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> >> ---
> >>  Makefile  | 5 ++++-
> >>  configure | 2 +-
> >>  2 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > LGTM
> 
> Unfortunately this does miss-detect an existing src link as directory, i.e.
> when re-running configure. And then the src link is not removed on distclean.
> 
> Attached is an updated patch without this problem.
> 
> Best regards,
> Andreas
> 

>  Makefile  |    5 ++++-
>  configure |    2 +-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 4a269f08d54798ae4d1863eefaa3a93527808f59  0001-configure-fall-back-to-using-full-path-if-src-is-a-d.patch
> From 99ebff03e8f5e8b9cfa248a723e217a20683a543 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Tue, 26 Jan 2016 22:54:01 +0100
> Subject: [PATCH] configure: fall back to using full path if src is a directory

patch should be ok

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160130/53af1d1a/attachment.sig>