[FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

[Michael Niedermayer]

On Wed, Jan 27, 2016 at 09:35:42AM +0000, Carl Eugen Hoyos wrote:
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> 
> >          if (!strcmp(x4->level, "1b")) {
> >              level_id = 9;
> > +        } else if (atoi(x4->level) > 9) {
> > +            level_id = atoi(x4->level);
> 
> Ping.
> 
> If this patch is not ok, please explain for 
> what input it behaves incorrectly.

it is "ok" but not robust

IIRC it depends on undocumented behavior of an external lib
that is libx264 checking the string ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160127/8643e984/attachment.sig>