[FFmpeg-devel] [PATCH]levc/hevc_cabac Optimise ff_hevc_hls_residual_coding (especially ARM)
Ronald S. Bultje
rsbultje at gmail.com
Tue Jan 19 14:40:21 CET 2016
On Tue, Jan 19, 2016 at 7:46 AM, John Cox <jc at kynesim.co.uk> wrote:
> I've just done a fair bit of work on hevc_cabac decode for the Rasberry
> Pi2 and I think that the patch is generally applicable. Patch is
> attached but you may prefer to take it from git:
Cool! Two non-technical comments first, I'll try to make time to review
> +#define UNCHECKED_BITSTREAM_READER 1
I don't think that's right, and is a security issue.
2: your indentation of function declarations is weird. E.g.:
+static inline uint32_t get_greaterx_bits(HEVCContext * const s, const
unsigned int n_end, int * const levels,
+ int * const pprev_subset_coded, int * const psum,
+ const unsigned int idx0_gt1, const unsigned int idx_gt2)
We tend to indent the second line so it aligns with the opening bracket of
the first line.
Alike, your indentation of const variable declarations:
+ uint8_t * const state0 = s->HEVClc->cabac_state + idx0_gt1;
doesn't need a space between * and const.
Like I said, all non-technical, I'll do technical bits soon if I find time.
If other people like it and I haven't responded yet, just commit it and we
can address them post-push.
More information about the ffmpeg-devel