[FFmpeg-devel] [PATCH] mpeg4videodec: silence ubsan warning

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Sat Jan 16 00:15:17 CET 2016


On 15.01.2016 03:17, Michael Niedermayer wrote:
> On Fri, Jan 15, 2016 at 12:30:28AM +0100, Andreas Cadhalpun wrote:
>> s->ac_val[0][0] is of type 'int16_t [16]', but points into a larger buffer.
>> Here it is used as base pointer to find the correct position in the
>> larger buffer by adding 's->block_index[n] * 16' and thus as 'int16_t *'.
>>
>> This fixes clang's ubsan runtime error: index out of bounds for type
>> 'int16_t [16]'
>>
>> Fixes: test_case.mp4
>>
>> Found-by: Tyson Smith <twsmith at mozilla.com>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> 
> LGTM

Pushed.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list