[FFmpeg-devel] [PATCH] lavf: add automatic bitstream filtering

Rodger Combs rodger.combs at gmail.com
Fri Jan 15 01:29:42 CET 2016


The init functions are required because avpriv_set_pts_info is called in write_header. Since this can affect operations that take place before write_header is called when delayed, it needs to be done earlier. This is probably also true of any other change to the AVFormatContext or AVStreams that could affect interleaving or related operations.

> On Jan 14, 2016, at 18:18, Moritz Barsnick <barsnick at gmx.net> wrote:
> 
> libavformat/movenc.c | 30 ++++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
> libavformat/flvenc.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
> 
> In the spirit of commits 1b5bd4051d1e394f0429cbf6cf6c137f55857478 and
> b287d7ea17f404a51eb3fdca80fa8a8b1fb7dd8b, where Rodger Combs applied
> his new mechanism of automatic bitstream filter insertion to
> lavf/mpegtsenc and lavf/matroskaenc, these patches add the
> aac_adtstoasc bsf to lavf/flvenc and lavf/movenc, replacing their
> error checks.
> 
> Rodger's commits also introduced *_init() functions for each format.
> I don't understand whether that is necessary. These patches work
> for me just as they are.
> 
> Tested against several input files containing and not containing ADTS.
> Fate was not run.
> 
> Please comment.
> 
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel



More information about the ffmpeg-devel mailing list