[FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

[Michael Niedermayer]

On Sun, Jan 10, 2016 at 10:04:34PM +0000, Ricardo Constantino wrote:
> On 10 January 2016 at 19:54, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> >
> > please explain in the commit message why secmem is disabled
> >
> >

>  rtmpdh.c |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> a340654ed5741348282a81f4d1065f85b26896be  0001-rtmpdh-Initialize-gcrypt-before-using-it.patch
> From 0225f408ef437e02d1dd5fc8e925e61120d56031 Mon Sep 17 00:00:00 2001
> From: Ricardo Constantino <wiiaboo at gmail.com>
> Date: Tue, 29 Dec 2015 21:40:14 +0000
> Subject: [PATCH] rtmpdh: Initialize gcrypt before using it
> 
> Either disabling or init'ing secure memory is required after the use
> of gcry_check_version. From a look at the functions rtmpdh uses, I
> noticed none require the use of secure memory, so we disable it [1][2].
> 
> This resolves some errors returned by rtmpdh code with uninitialized
> gcrypt, especifically:
> Fatal: failed to create the RNG lock: Invalid argument
> FATAL: failed to acquire the FSM lock in libgrypt: Invalid argument
> 
> Version "1.5.4" was arbitrarily chosen. An older version probably works
> as well, but I couldn't compile older versions to test on my machine.
> 
> [1]
> https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html
> [2]
> https://www.gnupg.org/documentation/manuals/gcrypt/Controlling-the-library.html
> 
> Signed-off-by: Ricardo Constantino <wiiaboo at gmail.com>
> ---
>  libavformat/rtmpdh.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160112/0accab49/attachment.sig>