[FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

[Michael Niedermayer]

On Mon, Jan 04, 2016 at 02:39:41AM +0000, Ricardo Constantino wrote:
> On 3 January 2016 at 23:13, Jan Ekstrom <jeebjp at gmail.com> wrote:
> 
> > Hi,
> >
> > In general looks good, although it might look a bit weird for someone
> > as usually libraries have initialization functions called like that.
> > That said, this is what
> >
> > https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html
> > recommends.
> >
> > My only comment would be that we might want to set the parameter to
> > GCRYPT_VERSION instead of NULL, as we most probably care if the
> > library loaded matches our version (unless these versions change even
> > if API doesn't change).
> >
> 
> This is where it shows my ignorance but I don't know which of these is the
> best way of dealing with that.
> I tested all three and they all work with the linked sample.

we should pass the version number we need i think
see
https://quickgit.kde.org/?p=libktorrent.git&a=commit&h=a23bafe9191e0dcbd5ae75335fd5d8e49bfda9ed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160110/da12ce9a/attachment.sig>