[FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

Rostislav Pehlivanov atomnuker at gmail.com
Fri Jan 1 22:23:09 CET 2016


>this would fail on beos acording to doc/errno.txt
Fixed, replaced with EINVAL in my private tree (
https://github.com/atomnuker/FFmpeg) and in the patch attached with this
email. Not sure how appropriate EINVAL is but other decoders use it too.

Also as suggested moved the vector functions to daala_pvq and unmarked the
larger functions as inline.

On 1 January 2016 at 20:44, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Fri, Jan 01, 2016 at 08:16:12PM +0000, Rostislav Pehlivanov wrote:
> [...]
>
> > +static av_cold int daala_decode_init(AVCodecContext *avctx)
> > +{
> > +    int i, r_w, r_h, err = 0;
> > +    DaalaContext *s = avctx->priv_data;
> > +
> > +    /* Inits a default QM, if the file isn't using the default it will
> be reinit */
> > +    s->last_qm = 1;
> > +    daala_init_qmatrix(s->pvq.qmatrix, s->pvq.qmatrix_inv, s->last_qm);
> > +
> > +    s->fmt = find_pix_fmt(avctx->pix_fmt);
> > +    if (!s->fmt) {
> > +        av_log(avctx, AV_LOG_ERROR, "Unsupported pixel format - %s!\n",
> > +               av_get_pix_fmt_name(avctx->pix_fmt));
>
> > +        return AVERROR(ENOTSUP);
>
> this would fail on beos acording to doc/errno.txt
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> It is what and why we do it that matters, not just one of them.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fixed-errors-on-BeOS-moved-functions-and-unmarked-so.patch
Type: text/x-patch
Size: 15781 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160101/22151a21/attachment.bin>


More information about the ffmpeg-devel mailing list