[FFmpeg-devel] [PATCH 4/7] vc2enc: clip and warn when user bitrate set too low

Moritz Barsnick barsnick at gmx.net
Sat Feb 27 22:24:08 CET 2016


On Sat, Feb 27, 2016 at 19:29:05 +0000, Rostislav Pehlivanov wrote:
> +        av_log(avctx, AV_LOG_WARNING,
> +               "Bitrate too low, clipping to minimum = %.2lf Mbps!\n",
> +               (double)avctx->bit_rate/1000000.0f);

"%lf" is undefined in C90, and otherwise identical to "%f".
libavutil/softfloat.c (and only that) does also use it though. ("%f" is
already double. There's no printf format specifier for float.)

And if you're going to make the division produce a double, you could
just as well use a double constant in it.

Too much nitpicking for a warning message, sorry,
Moritz


More information about the ffmpeg-devel mailing list