[FFmpeg-devel] [PATCH v7 1/3] mips: improve detection of ISAs, FPU and ASEs (DSP, MSA)

Michael Niedermayer michael at niedermayer.cc
Sat Feb 27 04:24:41 CET 2016


On Wed, Feb 24, 2016 at 04:38:20PM +0000, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera at imgtec.com>
> ---
> Changes v6 -> v7:
>  - Do not pass -msoft-float. Leave the mipsfpu handling as it was
>    before, so nothing changes. This could be improbed in the future.
> 
> Changes v5 -> v6:
>  - Multiple changes:
>    - Use separate if blocks when detecting the MIPS ISA, this way when a block
>      disables one ISA it will be detected by the next one. Before the elif was
>      preventing this to be done.
>    - Don't use check_cflags and use only check_ldflags instead, which will
>      check if that flag is valid for compiling and linking. The compiler may
>      accept some cflags for compiling but not for linking, so if we check first
>      for the cflags it will succeed, and the cflags will be added to the CFLAGS
>      variable despite of the check_ldflags failing after that. This can cause
>      problems because of having multiple incompatible cflags enabled at the same
>      time.
>    - Check if mipsfpu has been disabled, and if so, then use -msoft-float. This
>      way we override the compiler default behavious which can be building for
>      hard-float.
>    - Explicitly disable the features that fail any check by adding "|| disable
>      $feature" at the end of the checks chain.
> 
> Changes v4 -> v5:
>  - Check for msa.h and disable msa if not found.
> 
> Changes v3 -> v4:
>  - Nothing.
> 
> Changes v2 -> v3:
>  - Nothing.
> 
> Changes v1 -> v2:
>  - Add a block of code for mipsdspr2 which was previously placed in the
>    first patch of this series causing a syntax error in the configure
>    script.
>    https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183444.html
> 
>  configure | 101 +++++++++++++++++++++++++++++++++++++++++++++++++++-----------
>  1 file changed, 83 insertions(+), 18 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160227/ed0bbe98/attachment.sig>


More information about the ffmpeg-devel mailing list