[FFmpeg-devel] [PATCH v28] lavf/movenc: Add palette to video sample description

Mats Peterson matsp888 at yahoo.com
Fri Feb 26 23:21:19 CET 2016


Michael Niedermayer <michael at niedermayer.cc> skrev: (26 februari 2016 22:53:00 CET)
>On Fri, Feb 26, 2016 at 06:24:17AM +0100, Mats Peterson wrote:
>> On 02/26/2016 05:26 AM, Mats Peterson wrote:
>> >On 02/26/2016 05:08 AM, Mats Peterson wrote:
>> >>Should hopefully fix the big-endian issue.
>> >>
>> >
>> >Not that I understand why. I thought the palette was already in
>> >"big-endian" order, with the A, R, G, B bytes in that order, and
>that
>> >the previous patch would rather fail instead, so to say. But
>alright.
>> >
>> >Mats
>> >
>> >_______________________________________________
>> >ffmpeg-devel mailing list
>> >ffmpeg-devel at ffmpeg.org
>> >http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> 
>> 
>> After applying this patch, would you like to try "ffmpeg -i
>> 8bpp_129.mov -vcodec rawvideo out.mov" with the file below on that
>> mips machine, just to see that nothing is wrong with the palette
>> storage on the demuxer side?
>
>qemu-mips is free software, so is gcc, i think its more efficient
>if you test this yourself.
>... Considering the number of patch revissions ;)
>
>[...]

The number of revisions aren't because of not being able to test it on a big-endian machine. I had no idea about this issue until you told me about it. It can't be that hard to try these files on your  mips machine. Or are you perhaps using QEMU yourself? I actually installed it here today for the sole reason of testing with FFmpeg, but it is a slow, cpu-hungry bugger here that makes the fan on my laptop spin constantly.

So I'll ask you to check these files with version 28 in whatever way you want, since you mentioned the issue about wrong colors with v26. If there aren't any problems, please apply v28 unless there are more issues with it.

Mats 
-- 
Mats Peterson
http://matsp888.no-ip.org/~mats/


More information about the ffmpeg-devel mailing list