[FFmpeg-devel] [PATCH] vp9: add superframe merging bitstream filter.

[Michael Niedermayer]

On Tue, Feb 23, 2016 at 07:55:37AM -0500, Ronald S. Bultje wrote:
> Fixes ticket 4313.
> ---
>  ffmpeg.c                        |   3 +
>  libavcodec/Makefile             |   1 +
>  libavcodec/allcodecs.c          |   1 +
>  libavcodec/vp9_superframe_bsf.c | 189 ++++++++++++++++++++++++++++++++++++++++
>  libavformat/ivfenc.c            |  13 +++
>  libavformat/matroskaenc.c       |   5 +-
>  libavformat/mux.c               |  24 ++---
>  libavformat/utils.c             |   5 ++

this looks a bit like it should be split

about the size == 0 changes itself, iam not aware of anything it
breaks.
Its a question if any container-codec relies on packets with size=0

one file i found with such packets is
tickets/4758/1f534644-7da1-4f5f-a6bf-fc7ceb4f6072-P0.huffyuv

but the file seems to playback fine with the patch though differs in
that these packets are droped during stream copy.
In this specific case i see nothing wrong with droping these packets
and its probably better wthout the packets.
If this is always good or not i dont know ...

--- A   2016-02-26 21:58:33.875464116 +0100
+++ B   2016-02-26 21:58:42.395464296 +0100
@@ -1,21 +1,11 @@
 #extradata 0:      106, 0xa64116d1
 #extradata 1:       34, 0x339c0222
-#software: Lavf57.23.101
+#software: Lavf57.26.100
 #tb 0: 1/24
 #tb 1: 12/125
 0,          0,          0,        1,   179984, 0x7c9ecd1f
 1,          0,          0,        0,     5776, 0xa044b011
-1,          1,          1,        0,        0, 0x00000000
-1,          2,          2,        0,        0, 0x00000000
 0,          5,          5,        1,   181924, 0xbe21e45c
-1,          3,          3,        0,        0, 0x00000000
-1,          4,          4,        0,        0, 0x00000000
 0,         10,         10,        1,   193376, 0x3109c167
-1,          5,          5,        0,        0, 0x00000000
-1,          6,          6,        0,        0, 0x00000000
 0,         16,         16,        1,   206656, 0x8a1b8e41
-1,          7,          7,        0,        0, 0x00000000
-1,          8,          8,        0,        0, 0x00000000
-1,          9,          9,        0,        0, 0x00000000
 0,         21,         21,        1,   190712, 0xd9f6bb30
-1,         10,         10,        0,        0, 0x00000000



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160226/5f08a625/attachment.sig>