[FFmpeg-devel] [PATCH] lavf/mux: do not fail in case of non monotonically increasing DTS values for data packets

Michael Niedermayer michael at niedermayer.cc
Tue Feb 23 20:32:23 CET 2016


On Tue, Feb 23, 2016 at 07:34:16PM +0100, Stefano Sabatini wrote:
> On date Saturday 2016-02-13 18:46:55 +0100, Stefano Sabatini encoded:
> > On date Friday 2015-05-01 19:10:17 +0200, Stefano Sabatini encoded:
> > > On date Thursday 2015-04-30 16:24:08 +0200, Michael Niedermayer encoded:
> > > > On Thu, Apr 30, 2015 at 02:20:52PM +0200, Stefano Sabatini wrote:
> > > > > Disable monotonicity test for data packets. Data packets are not supposed
> > > > > to be decoded by FFmpeg, and this checks cause conversion failure with
> > > > > some files with non strictly monotonous timestamps.
> > > > > ---
> > > > >  libavformat/mux.c | 5 +++--
> > > > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > > 
> > > > most muxers will not work with packets which arent ordered no matter
> > > > what type the packets are
> > > 
> > > Fine, I will drop the patch. The application level can take care of
> > > that if needed (by sorting the misordered packets).
> > 
> > I have an use case with data packets that have the same PTS (which
> > makes sense in that specific case). Since I want to fix this issue,
> > and dropping the check inconditionally may not be acceptable, I
> > propose the following variants:
> > 
> > * I add an option to drop strict monotonicity checks on data packets
> > 
> > * I enable a format level capability which disables the strict
> >   monotonicity requirement for data packets depending on the format
> > 
> > What do you find acceptable?

i think its fine to treat data the same as subtitles


> 
> Ping.
> -- 
> FFmpeg = Forgiving Forgiving Mournful Pitiful Enhancing Ghost
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160223/c00f0cc9/attachment.sig>


More information about the ffmpeg-devel mailing list