[FFmpeg-devel] [PATCH v6] Added VideoToolbox H.264 encoder.

wm4 nfxjfg at googlemail.com
Mon Feb 22 11:49:10 CET 2016


On Wed, 17 Feb 2016 18:30:04 +0800
Rick Kern <kernrj at gmail.com> wrote:

> Autodetected by default. Encode using -codec:v vtenc.
> 
> Signed-off-by: Rick Kern <kernrj at gmail.com>
> ---

The configure check doesn't work. It tries to enable it on non-OSX,
which breaks building ffmpeg out of the box on anything but OSX.

Also, I noticed that the existing code for the videotoolbox hwaccel
adds a bunch of frameworks, while yours adds only VideoToolbox. If the
existing code wrong, or your code?

While we're at it, avoid past tense in commit messages for things the
commit changes.


More information about the ffmpeg-devel mailing list