[FFmpeg-devel] [PATCH] lavc/libvpx: fix support for RGB colorspace.

Hendrik Leppkes h.leppkes at gmail.com
Fri Feb 19 09:16:48 CET 2016


On Fri, Feb 19, 2016 at 8:16 AM, James Zern <jzern at google.com> wrote:
> On Thu, Feb 18, 2016 at 3:02 PM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>> On Thu, Feb 18, 2016 at 11:59 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>>> On Thursday 18 February 2016 09:40:01 pm Nicolas George wrote:
>>>> Initial patch by Carl Eugen Hoyos.
>>>>
>>>> Fix trac ticket #5249.
>>>
>>> Patch with (automatic) support for 8, 10 and 12 bit gbr attached.
>>>
>>> Please comment, Carl Eugen
>>
>> This lacks the appropriate changes in libvpx.c to the supported pixel
>> formats for the encoder.
>> Also, please re-indent appropriately. If its not in this patch, it'll
>> never get done.
>>
>
> There was a historical preference not to do that, the developer docs
> still say something to that effect [1]. If the preference has changed
> then I'm OK with it.
>
> [1] http://ffmpeg.org/developer.html#Development-Policy
> "8. We refuse source indentation and other cosmetic changes if they
> are mixed with functional changes, such commits will be rejected and
> removed."

Well that would be nice and all, but in many of those cases the code
is never re-indented afterwards, and leaves a unreadable mess in the
code, so thats even worse.
Any good diff viewer will highlight actual changes and ignore
whitespace, as well.

This should probably be reworded so it doesn't sound as strongly.

- Hendrik


More information about the ffmpeg-devel mailing list