[FFmpeg-devel] [PATCH v2] avfilter/avf_showcqt: improve pts handling

Michael Niedermayer michael at niedermayer.cc
Wed Feb 17 15:55:29 CET 2016


On Wed, Feb 17, 2016 at 12:33:49PM +0100, Paul B Mahol wrote:
> On 2/17/16, wm4 <nfxjfg at googlemail.com> wrote:
> > On Wed, 17 Feb 2016 10:39:30 +0100
> > Paul B Mahol <onemda at gmail.com> wrote:
> >
> >> On 2/16/16, Muhammad Faiz <mfcc64 at gmail.com> wrote:
> >> > correct output pts based on input pts
> >> > make seeking possible
> >> > output frame one by one on eof
> >> > tested with showinfo filter
> >> >
> >> > patch attached
> >> >
> >> > thank's
> >> >
> >>
> >> Tested with mpv, works, so LGTM.
> >
> > I don't think that's sufficient. Also, the patch author said something
> > about seeking - I'm not sure what that means (since libavfilter doesn't
> > support seeking, not even flushing), and mpv in particular just
> > destroys and recreates the entire graph on seeking out of necessity.
> 
> It means what I said, patch LGTM.

applied

thanks

PS: Muhammad, if you want git write access to maintain this filter,
just say so.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160217/cc79ba53/attachment.sig>


More information about the ffmpeg-devel mailing list