[FFmpeg-devel] [PATCH v2] avfilter/avf_showcqt: improve pts handling

Paul B Mahol onemda at gmail.com
Wed Feb 17 12:33:49 CET 2016


On 2/17/16, wm4 <nfxjfg at googlemail.com> wrote:
> On Wed, 17 Feb 2016 10:39:30 +0100
> Paul B Mahol <onemda at gmail.com> wrote:
>
>> On 2/16/16, Muhammad Faiz <mfcc64 at gmail.com> wrote:
>> > correct output pts based on input pts
>> > make seeking possible
>> > output frame one by one on eof
>> > tested with showinfo filter
>> >
>> > patch attached
>> >
>> > thank's
>> >
>>
>> Tested with mpv, works, so LGTM.
>
> I don't think that's sufficient. Also, the patch author said something
> about seeking - I'm not sure what that means (since libavfilter doesn't
> support seeking, not even flushing), and mpv in particular just
> destroys and recreates the entire graph on seeking out of necessity.

It means what I said, patch LGTM.

It doesnt anymore creates frame pts out of nothing but takes into account
input frame pts. When mpv seeks with complex filter graph it recreates
filtergraph but it doesn't resets pts to start from 0, and why would it.


More information about the ffmpeg-devel mailing list