[FFmpeg-devel] [PATCH] avcodec: only warn about hwaccel with frame threads

Ronald S. Bultje rsbultje at gmail.com
Sun Feb 14 01:19:45 CET 2016


Hi,

On Sat, Feb 13, 2016 at 2:38 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> On Sat, Jan 23, 2016 at 11:42:54AM +0100, Hendrik Leppkes wrote:
> > On Sat, Jan 23, 2016 at 10:12 AM, Andreas Cadhalpun
> > <andreas.cadhalpun at googlemail.com> wrote:
> > > VLC uses hwaccel with frame threads and it works fine, but returning
> > > an error here made it fail.
> > >
> > > This regression was introduced in commit 31741ae.
> > >
> >
> > I'm still opposed to this, and so is everyone else that commented on the
> issue.
> > Also, the vp9 hwaccel will most definitely misbehave with MT, so this
> > one needs to be re-factored before MT is allowed at the very least.
>
> vp9 has been fixed
>
> from IRC:
>
> <michaelni> BBB, can the vp9 & hwaccel-mt patches be applied or is there a
> reason to wait ?
> <BBB> no reason to wait, can be applied
> <BBB> sorry, I haven’t kept track very closely of that patch
> <BBB> I can apply if you want, but it’s probably faster if you merge for me
> <BBB> I believe with that patch, we can revert the previous patch that
> prevented mt+hwaccel, as andreas requested
> <BBB> it will still not work for dxva2, but that’s unrelated to vp9 since
> it fails for h264 also
> <michaelni> i can apply the patchs, i just dont want to step on anyones
> toes, the vp9 one seems clear but which is the 2nd one, the one from anreas
> that changes it to a warning or revert 31741ae ?
>
> just want to make double sure i dont step on anyones toes, thus asking
> on the ML here too before applying the patch


I think it's fine to apply, please ask for Hendrik's opinion also.

Ronald


More information about the ffmpeg-devel mailing list