[FFmpeg-devel] [PATCH] lavf/mux: do not fail in case of non monotonically increasing DTS values for data packets

Stefano Sabatini stefasab at gmail.com
Sat Feb 13 18:46:55 CET 2016


On date Friday 2015-05-01 19:10:17 +0200, Stefano Sabatini encoded:
> On date Thursday 2015-04-30 16:24:08 +0200, Michael Niedermayer encoded:
> > On Thu, Apr 30, 2015 at 02:20:52PM +0200, Stefano Sabatini wrote:
> > > Disable monotonicity test for data packets. Data packets are not supposed
> > > to be decoded by FFmpeg, and this checks cause conversion failure with
> > > some files with non strictly monotonous timestamps.
> > > ---
> > >  libavformat/mux.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > most muxers will not work with packets which arent ordered no matter
> > what type the packets are
> 
> Fine, I will drop the patch. The application level can take care of
> that if needed (by sorting the misordered packets).

I have an use case with data packets that have the same PTS (which
makes sense in that specific case). Since I want to fix this issue,
and dropping the check inconditionally may not be acceptable, I
propose the following variants:

* I add an option to drop strict monotonicity checks on data packets

* I enable a format level capability which disables the strict
  monotonicity requirement for data packets depending on the format

What do you find acceptable?
-- 
FFmpeg = Faithless Fantastic Most Prodigious Explosive Generator


More information about the ffmpeg-devel mailing list