[FFmpeg-devel] [PATCH v9] lavc/rawdec: Remove monowhite switching code for 1 bpp AVI without a palette

[Mats Peterson]

On 02/13/2016 05:39 AM, Mats Peterson wrote:
> On 02/13/2016 12:51 AM, Michael Niedermayer wrote:
>
>>> +        if (context->has_pkt_pal) {
>>> +            memcpy(context->palette->data,
>>> +                   avpkt->data + avpkt->size - AVPALETTE_SIZE,
>>> AVPALETTE_SIZE);
>>
>> This is incorrect, the 8bit palette in nut can have any number of
>> entries up to 256, this assumes its fixed 256
>>
>
> I had absolutely no idea, Michael. I'm doing my best ;) It would be much
> easier and more consequent if it used AVPALETTE_SIZE, though.
>

Once again, how are we supposed to know how many colors the palette 
consists of at the end of avpkt->data?

Mats