[FFmpeg-devel] [PATCH] alac: allow extra data without the ATOM header

[Michael Niedermayer]

On Fri, Feb 12, 2016 at 05:05:00PM +0100, Steve Lhomme wrote:
> From: Steve Lhomme <robux4 at gmail.com>
> 
> --
> can be found in such sample http://streams.videolan.org/issues/16620/VLCSupportsample.mkv
> ---
>  libavcodec/alac.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

this breaks fate

make fate-alac
TEST    alac-16-level-0
Test alac-16-level-0 failed. Look at tests/data/fate/alac-16-level-0.err for details.
make: *** [fate-alac-16-level-0] Error 1

[alac @ 0x2a75120] extradata is too small
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x2a73fe0] Failed to open codec in av_find_stream_info
[alac @ 0x2a75120] extradata is too small
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/home/michael/ffmpeg-git/ffmpeg/tests/data/fate/alac-16-level-0.mov':
  Metadata:
    major_brand     : qt
    minor_version   : 512
    compatible_brands: qt
    encoder         : Lavf57.25.100
  Duration: 00:00:09.50, start: 0.000000, bitrate: 1412 kb/s
    Stream #0:0(eng): Audio: alac (alac / 0x63616C61), 44100 Hz, stereo, 1411 kb/s (default)
    Metadata:
      handler_name    : DataHandler
[abuffer @ 0x2a8eae0] Unable to parse option value "(null)" as sample format
    Last message repeated 1 times
[abuffer @ 0x2a8eae0] Error setting option sample_fmt to value (null).
[graph 0 input from stream 0:0 @ 0x2a73a60] Error applying options to the filter.
Error opening filters!

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160212/a401cf50/attachment.sig>