[FFmpeg-devel] [PATCH] avfilter: add metadata filters

Paul B Mahol onemda at gmail.com
Sat Feb 6 23:31:06 CET 2016


On 2/6/16, Moritz Barsnick <barsnick at gmx.net> wrote:
> On Sat, Feb 06, 2016 at 12:47:25 +0100, Paul B Mahol wrote:
>> patch attached.
>
> Nice. (Untested.)
>
>
>
>> +Manipulate frames metadata.
>   Either:
>     frame metadata [using this as a generic term]
>   or:
>     frames' metadata
>
> I prefer the former.
>
>> +If both @code{value} and @code{key} is set, select frame
>                                                       ^^^^^ frames (plural)
>> +every frame that have such key in metadata.
>                     ^^^^ has (singular)
>
>> +Print key and value if metadata was found.
> I'm not sure I've understood whether this can apply to only matching
> metadata (key, key/value), or to any metadata.
>
>> +Set metadata value which will be used. This option is mandatory for
>> modify
>> +and add mode.
>   for 'modify' and 'add' modes (note the quoting and the plural).
>
>> +Set length of how much characters of two metadata values need to match to
>> be
>                      ^^^^ many

All should be resolved in newer version. Thanks for feedback.


More information about the ffmpeg-devel mailing list