[FFmpeg-devel] [PATCH 1/2] dirac_dwt: Don't pass information in context as arguments

Rostislav Pehlivanov atomnuker at gmail.com
Sat Feb 6 12:08:16 CET 2016


On 6 February 2016 at 03:37, Timothy Gu <timothygu99 at gmail.com> wrote:

> ---
>  libavcodec/dirac_dwt.c          | 13 ++++++++++---
>  libavcodec/dirac_dwt_template.c | 25 +++++++++----------------
>  2 files changed, 19 insertions(+), 19 deletions(-)
>
>
LGTM

d->temp = (uint8_t *)(((TYPE *)d->temp) + 8); might appear confusing
to someone as it modifies the actual pointer but that's okay since the
pointer itself is supplied upon DWT init which happens on every single
frame (since the wavelet transforms can differ between frames).


Thanks


More information about the ffmpeg-devel mailing list