[FFmpeg-devel] [PATCH] avformat/mp3enc: Assert that the header we assembled is valid

Michael Niedermayer michael at niedermayer.cc
Sat Feb 6 11:32:13 CET 2016


On Fri, Feb 05, 2016 at 10:41:26AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Feb 5, 2016 at 9:34 AM, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> 
> > On Fri, Feb 5, 2016 at 3:33 PM, Derek Buitenhuis
> > <derek.buitenhuis at gmail.com> wrote:
> > > On 2/5/2016 2:19 PM, Michael Niedermayer wrote:
> > >> because the code builds the header a few lines above, i assume
> > >> the header we just build is correct
> > >
> > > Perhaps you could elaborate what CID1351343 is then, in the commit
> > > messages.
> > >
> >
> > A Coverity ID, a false positive which we decide to "fix" with an
> > assertion instead of marking it as such in the tool?
> 
> 
> So, I don't mind the patch, that's fine. But the commit message is
> misleading. It suggests that there's a bug and that this patch fixes the
> bug. That's incorrect. There is no bug, and this patch does not fix
> anything. It asserts something, and as asserts go, they don't fix anything,
> they just assert (=confirm) expected behaviour.
> 
> So, can we change the commit message to not include the word "fix" or any
> other misleading derivative thereof?

absolutely, agree
do you want to suggest some wording ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160206/7ec48928/attachment.sig>


More information about the ffmpeg-devel mailing list