[FFmpeg-devel] [PATCH] avfilter/af_apulsator: assert that pathes leaving uninitialized variables do not occur

Paul B Mahol onemda at gmail.com
Thu Feb 4 10:14:53 CET 2016


On 2/4/16, Michael Niedermayer <michael at niedermayer.cc> wrote:
> Fixes: CID1341581, CID1341582
>
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavfilter/af_apulsator.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/libavfilter/af_apulsator.c b/libavfilter/af_apulsator.c
> index 6c81530..802b8d0 100644
> --- a/libavfilter/af_apulsator.c
> +++ b/libavfilter/af_apulsator.c
> @@ -18,6 +18,7 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
> USA
>   */
>
> +#include "libavutil/avassert.h"
>  #include "libavutil/opt.h"
>  #include "avfilter.h"
>  #include "internal.h"
> @@ -117,6 +118,7 @@ static double lfo_get_value(SimpleLFO *lfo)
>      case SAWDOWN:
>          val = 1 - phs * 2;
>          break;
> +    default: av_assert0(0);
>      }
>
>      return val * lfo->amount;
> @@ -207,6 +209,7 @@ static int config_input(AVFilterLink *inlink)
>      case UNIT_BPM:  freq = s->bpm / 60;         break;
>      case UNIT_MS:   freq = 1 / (s->ms / 1000.); break;
>      case UNIT_HZ:   freq = s->hz;               break;
> +    default: av_assert0(0);
>      }
>
>      s->lfoL.freq   = freq;
> --
> 1.7.9.5
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

ok


More information about the ffmpeg-devel mailing list