[FFmpeg-devel] [PATCH 1/2] Add TargetTypeValue in Matroska tag prefix

Carl Eugen Hoyos cehoyos at ag.or.at
Tue Feb 2 19:40:59 CET 2016


Pierre Choffet <peuc <at> wanadoo.fr> writes:

> -            matroska_convert_tag(s, &tags[i].tag, &s->metadata,

The patch will get more readable if you don't change this 
line.
And please add parenthesis around your else statement, they 
make the code easier to read.

You have to merge the two patches: There should be no 
commit that breaks running fate.

Carl Eugen



More information about the ffmpeg-devel mailing list