[FFmpeg-devel] [PATCH 2/2] fate: re-enable dca-xll test

James Almer jamrial at gmail.com
Mon Feb 1 16:14:03 CET 2016


On 2/1/2016 6:10 AM, Hendrik Leppkes wrote:
> On Mon, Feb 1, 2016 at 4:36 AM, James Almer <jamrial at gmail.com> wrote:
>> And check for bitexact output instead
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> The samples in https://github.com/foo86/dcadec-samples will have to
>> be added eventually to fully test all the DTS extensions.
>>
>>  tests/fate/audio.mak   | 3 +++
>>  tests/ref/fate/dca-xll | 1 +
>>  2 files changed, 4 insertions(+)
>>  create mode 100644 tests/ref/fate/dca-xll
>>
>> diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
>> index 93c19a0..5a36db2 100644
>> --- a/tests/fate/audio.mak
>> +++ b/tests/fate/audio.mak
>> @@ -21,6 +21,9 @@ fate-dca-core: CMD = pcm -i $(TARGET_SAMPLES)/dts/dts.ts
>>  fate-dca-core: CMP = oneoff
>>  fate-dca-core: REF = $(SAMPLES)/dts/dts.pcm
>>
>> +FATE_DCA-$(call DEMDEC, DTS, DCA) += fate-dca-xll
>> +fate-dca-xll: CMD = md5 -i $(TARGET_SAMPLES)/dts/master_audio_7.1_24bit.dts -f s24le
>> +
>>  FATE_SAMPLES_AUDIO-$(CONFIG_DCA_DECODER) += $(FATE_DCA-yes)
>>  fate-dca: $(FATE_DCA-yes)
>>
>> diff --git a/tests/ref/fate/dca-xll b/tests/ref/fate/dca-xll
>> new file mode 100644
>> index 0000000..f7e9200
>> --- /dev/null
>> +++ b/tests/ref/fate/dca-xll
>> @@ -0,0 +1 @@
>> +5eb9a95ddaf3c803e74443a49a691686
>> --
>> 2.7.0
>>
> 
> The sample already exists in the fate suite, so no harm in testing it
> again in any case.
> 
> Would be nice to support all the new samples from the dcadec test
> suite,  however the lossy modes will probably need PCM references
> instead of md5's, float decoding can't be trusted. ;)
> 
> - Hendrik

They are available in the suit from the link above, so it shouldn't be a problem.

Patchset pushed, thanks.


More information about the ffmpeg-devel mailing list