[FFmpeg-devel] Workaround for VS 2015 Update 1 bug

Hendrik Leppkes h.leppkes at gmail.com
Mon Feb 1 10:43:39 CET 2016


On Thu, Jan 28, 2016 at 10:58 PM, Bruce Dawson <brucedawson at google.com> wrote:
>> Can you elaborate which test should be failing?
>
> Sure.
>
> The test that is failing is not in the ffmpeg repo, but it uses the ffmpeg
> repo. The Chromium test that fails (debug and release because we always
> compile ffmpeg optimized) is this one:
>
> media_unittests.exe --single-process-tests
> --gtest_filter=AudioVideoMetadataExtractorTest.AudioWAV
>
> Because ff_read_riff_info() ends up not null-terminating the key array it
> means that the value of 'key' passed to av_dict_set() is undefined. In some
> cases it might actually be correct, or it could be an arbitrarily long
> string, or their could be an access violation.
>
> It is also possible to verify the bug through inspection of the generated
> code, but that is tedious. More details, including a minimal repro, can be
> found in the connect bug:
>
> https://connect.microsoft.com/VisualStudio/feedback/details/2291638
>

Applied, thanks.

- Hendrik


More information about the ffmpeg-devel mailing list