[FFmpeg-devel] [PATCH 6/9] lavfi: move AVFilterLink declaration to its own header.

James Almer jamrial at gmail.com
Tue Dec 27 23:08:43 EET 2016


On 12/27/2016 5:40 PM, Nicolas George wrote:
> Le septidi 7 nivôse, an CCXXV, James Almer a écrit :
>> Where have i heard this before? Something something ffserver.
> 
> Actually, for ffserver, it turned out that there was no decision at all.

There sure was. A discussion, a decision, and a patch, all without opposition until
months later when they were going to be made effective.
Unlike some of these avfilter changes you're pushing, which went in despite having
people questioning them.

> 
> And for ffserver, the situation changed between the pretended decision
> and the revoke. No situation changed here.
> 
>> Not to mention it's a lie. There was a review you purposely (and proudly!) ignored.
>> I think that's as far as "consensus" as it can get.
> 
> The "review" you are referring to was for another patch entirely.
> 

That patch was a dependency for the one we're talking about here. With the dependency
blocked, the following one is just as blocked. Last i checked, you didn't re-implement
it without the FFFrameQueue api to free it from said blockage.

> I will see if you do the right thing about that in your next message.

More "I'm right, you're wrong, and I'm simply letting you know it" attitude.
That sure helps you argument.

> 
>>>> It's clear you're on the defensive and think I'm just attacking you for the sake
>>>> of it, so trying to discuss with you will be pointless.
>>> Self-fulfilling prophecy.
>> I have no fucking idea what you're even trying to imply here. At this point i don't
>> think you're even addressing what I'm saying, but what the evil version of myself
>> that resides in your mind says instead.
> 
> Usually, when someone says "trying to discuss with you will be
> pointless", the problem lies with the one who is saying that, not the
> other one.

I made three questions. All of them where ignored, and what i got instead was a "You
are late, this is not new code". Do you honestly consider discussing with you will get
us anywhere if that's your first reaction at a normal and completely valid reply to
your patch?

> 
>> Learn to handle criticism to your code already and stop taking everything as a
>> personal attack. It will help people tolerate you.
> 
> I can take criticism, but I do not like nagging.

What nagging? You got dissenting opinions and technical concerns about your code from
more than one developer. You in turn ignored and belittled most if not all of them,
and those behind them as well.
You're the only person on this list that constantly reacts like this. This project
would be dead and lacking contributors if every single person handled reviews even
remotely like you.



More information about the ffmpeg-devel mailing list