[FFmpeg-devel] [PATCH] avdevice/decklink_enc: do not reference this after freeing it

Marton Balint cus at passwd.hu
Tue Dec 27 02:24:56 EET 2016


On Sat, 10 Dec 2016, Marton Balint wrote:

> Fixes Coverity CID 1396863.
>
> Signed-off-by: Marton Balint <cus at passwd.hu>
> ---
> libavdevice/decklink_enc.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp
> index dc4a24b..ad00224 100644
> --- a/libavdevice/decklink_enc.cpp
> +++ b/libavdevice/decklink_enc.cpp
> @@ -55,7 +55,7 @@ public:
>
>     virtual HRESULT STDMETHODCALLTYPE QueryInterface(REFIID iid, LPVOID *ppv) { return E_NOINTERFACE; }
>     virtual ULONG   STDMETHODCALLTYPE AddRef(void)                            { return ++_refs; }
> -    virtual ULONG   STDMETHODCALLTYPE Release(void)                           { if (!--_refs) delete this; return _refs; }
> +    virtual ULONG   STDMETHODCALLTYPE Release(void)                           { if (!--_refs) {delete this; return 0;} return _refs; }
>
>     struct decklink_ctx *_ctx;
>     AVFrame *_avframe;
> --

Applied.

Regards,
Marton


More information about the ffmpeg-devel mailing list