[FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

Nicolas George george at nsup.org
Thu Dec 22 13:18:28 EET 2016


Le primidi 1er nivôse, an CCXXV, Marton Balint a écrit :
> It seems after this patch I got an infinite loop if I try to convert the
> attached file using this command line:
> 
> ./ffmpeg -i amerge-test.mov -filter_complex "[0:a:0][0:a:1]amerge=2[aout]"
> -map "[aout]" out.wav

Can you confirm the attached patch fixes the issue?

If so, please do not hesitate to push it without waiting for me if (and
only if) that is convenient for you.

> Note that in my build FF_BUFQUEUE_SIZE in libavfilter/bufferqueue.h is set
> to 256, because otherwise it errors out with ENOMEM, but that also happens
> with the old filtering code. On the other hand, the old filtering code and
> FF_BUFQUEUE_SIZE set to 256 does allow the file to properly convert.

I wish I remembered that precision before spending time tracking the
ENOMEM :(

Fortunately, one of the perks of these changes is they are a step closer
to getting rid of that particular issue once and for all. I suspect
rudimentary memory limitation will be needed first, but that can be
managed.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-af_amerge-detect-EOF-immediately.patch
Type: text/x-diff
Size: 1191 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161222/1e6a18c8/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161222/1e6a18c8/attachment.sig>


More information about the ffmpeg-devel mailing list