[FFmpeg-devel] [PATCH] avutil: Added selftest for libavutil/audio_fifo.c

Michael Niedermayer michael at niedermayer.cc
Thu Dec 22 03:49:49 EET 2016


On Wed, Dec 21, 2016 at 09:45:39PM -0300, James Almer wrote:
> On 12/20/2016 11:36 PM, Michael Niedermayer wrote:
> > On Tue, Dec 20, 2016 at 04:53:51PM -0800, Thomas Turner wrote:
> >> Signed-off-by: Thomas Turner <thomastdt at googlemail.com>
> >> ---
> >>  libavutil/Makefile           |   1 +
> >>  libavutil/tests/audio_fifo.c | 196 +++++++++++++++++++++++++++++++++++++
> >>  tests/fate/libavutil.mak     |   4 +
> >>  tests/ref/fate/audio_fifo    | 228 +++++++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 429 insertions(+)
> >>  create mode 100644 libavutil/tests/audio_fifo.c
> >>  create mode 100644 tests/ref/fate/audio_fifo
> > 
> > applied
> > 
> > thx
> 
> This is crashing on some fate clients.
> 
> I noticed it's using malloc and free instead of the av_malloc family,
> so maybe it's related to that?
> Patch attached in any case, it's proper even if not the reason behind
> the crashes.

i saw the malloc/free before applying. It seemed to make sense to
use libc functions in a test of our public API

why is it crashing ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Modern terrorism, a quick summary: Need oil, start war with country that
has oil, kill hundread thousand in war. Let country fall into chaos,
be surprised about raise of fundamantalists. Drop more bombs, kill more
people, be surprised about them taking revenge and drop even more bombs
and strip your own citizens of their rights and freedoms. to be continued
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161222/8ce55001/attachment.sig>


More information about the ffmpeg-devel mailing list