[FFmpeg-devel] [PATCH 2/2] wmavoice: don't error out if we're skipping more bits than available.

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Tue Dec 20 02:10:40 EET 2016


On 20.12.2016 00:59, Carl Eugen Hoyos wrote:
> 2016-12-19 23:45 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>> On 16.12.2016 14:19, Ronald S. Bultje wrote:
>>> This reverts 2a4700a4f03280fa8ba4fc0f8a9987bb550f0d1e and implements it
>>> correctly so streams actually decode the way the encoder intended them
>>> to.
>>
>> Why is it correct?
> 
> Because the patch introduced an (imo horrible) regression,

I don't think that not triggering an av_assert0 is a regression.

> files that before reported why they couldn't be played suddenly
> gave no explanation, just a useless error message.

An error message is not no explanation.

Best regards,
Andreas



More information about the ffmpeg-devel mailing list