[FFmpeg-devel] [PATCH] ffmpeg: add ffmpeg_d3d11va

compn tempn at mi.rr.com
Thu Dec 15 02:23:42 EET 2016


On Wed, 14 Dec 2016 11:44:13 +0100
wm4 <nfxjfg at googlemail.com> wrote:

> On Wed, 14 Dec 2016 09:30:35 +0000
> Stève Lhomme <robux4 at videolabs.io> wrote:
> 
> > On Tue, Dec 13, 2016 at 2:35 PM, wm4 <nfxjfg at googlemail.com> wrote:
> > > On Tue, 13 Dec 2016 14:19:35 +0100
> > > Steve Lhomme <robux4 at gmail.com> wrote:
> 
> > >
> > > I'm pretty much against this, since it duplicates the profile
> > > selection code all over again, even if it could be shared. (And
> > > this code should be in libavcodec in the first place.) Someone
> > > adding such code would have to refactor ffmpeg_d3d11va too.  
> > 
> > I'm not sure how this relates to the line above. d3d11va and dxva2
> > are definitely not the same thing. On mobile you do not have DXVA2
> > at all but D3D11(VA) is present. There must be a way to have one
> > without the other.
> 
> Yeah, but selection of the decoder GUIDs is very similar between both
> APIs. It can definitely be shared (we do this in mpv). There's
> absolutely no reason to copy-paste that stuff from ffmpeg_dxva2.c into
> ffmpeg_d3d11va.c.
> 

is having this duplication a blocker to this patch would you say?

> As for how libavcodec can do provide this part, see the Libav/avconv
> vaapi support (none of that is in ffmpeg yet).

same question here.

i am not arguing one way or the other, just asking.

-compn


More information about the ffmpeg-devel mailing list