[FFmpeg-devel] [PATCH 1/2] configure: fix nvenc detection logic

[Timo Rothenpieler]

On 8/31/2016 5:42 PM, Carl Eugen Hoyos wrote:
> 2016-08-31 17:32 GMT+02:00 James Almer <jamrial at gmail.com>:
>> On 8/31/2016 11:58 AM, Carl Eugen Hoyos wrote:
>>> 2016-08-31 16:42 GMT+02:00 Timo Rothenpieler <timo at rothenpieler.org>:
>>>
>>>> +if enabled x86; then
>>>> +    case $target_os in
>>>> +        mingw32*|mingw64*|win32|win64|linux|cygwin*)
>>>> +            ;;
>>>> +        *)
>>>> +            disable nvenc
>>>> +            ;;
>>>> +    esac
>>>> +else
>>>> +    disable nvenc
>>>>  fi
>>>
>>>> +enabled nvenc &&
>>>> +    check_cc -I$source_path <<EOF || disable nvenc
>>>
>>> Why is the complicated part above still necessary with
>>> this check?
>>
>> This test makes sure broken compilers like msvc 2012 don't enable nvenc.
> 
> I wonder now if the new check can also test for x86 Windows or Linux.

That's quite exactly what it's doing.
Those are the targets where nvenc works, provided it's on x86.
Which essentialy is any x86 Linux and Windows system.
I'm wondering about ARM Windows now though.

>> But otherwise, without the above arch and OS checks it would succeed on
>> pretty much any target since it simply compiles a standalone header.
> 
> Thank you.
> 
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>