[FFmpeg-devel] [PATCH] avcodec/nvenc: Include nvEncodeAPI v7 SDK header

[Matt Oliver]

On 27 August 2016 at 23:12, Timo Rothenpieler <timo at rothenpieler.org> wrote:

> On 8/27/2016 3:07 PM, Thomas Volkert wrote:
> > Hi,
> >
> > On 27.08.2016 14:58, Timo Rothenpieler wrote:
> >> As Nvidia has put the most recent Video Codec SDK behind a double
> >> registration wall, of which one needs manual approval of a lenghty
> >> application, bundling this header saves everyone trying to use NVENC
> >> from that headache.
> >>
> >> The header is still MIT licensed and thus fine to bundle with ffmpeg.
> >>
> >> Not bundling this header would get ffmpeg stuck at SDK v6, which is
> >> still freely available, holding back future development of the NVENC
> >> encoder.
> >> ---
> >>  compat/nvenc/nvEncodeAPI.h | 3219 ++++++++++++++++++++++++++++++
> ++++++++++++++
> >>  configure                  |   22 +-
> >>  libavcodec/nvenc.h         |    2 +-
> >>  3 files changed, 3237 insertions(+), 6 deletions(-)
> >>  create mode 100644 compat/nvenc/nvEncodeAPI.h
> >>
> >
> > But this approach assumes to have SDK version 7 in every case -
> > independent from the actually available revision at runtime?
> > Is it possible to check the actually available version during runtime?
>
> The header is all SDK the nvenc encoder needs, there is no runtime
> component except for the Nvidia driver.
>
> >
> > And I think there are some deprecated comments in nvenc.c:
> > - references to only H.264 (HEVC was already added)
> > - references to version 5 as "current SDK revision"
>
> There might be some outdated comments left over, but nothing that's a
> major documentation issue.
> Or do you have something specific in mind?
>
> >
> > Best regards,
> > Thomas.
> >


With the new registration wall Im actually in favor of adding this to the
repo as only the header is needed and the header can no longer be
downloaded easily with build bots or similar which breaks online build/CI
systems. Having this available in the repo would make things a lot easier
for a lot of people.